docs: add storage configuration block for eks_cluster resource

[stefanfreitag]

Description

• The resource aws_eks_cluster contains a storage_config block, see e.g. example code available here.
• The provider documentation is missing details on the storage_config.

The pull requests

• adds the missing documentation for storage_config
• adds links from "config block" argument to the corresponding description.

Relations

Closes #41226

References

• AWS Provider Source code

Output from Acceptance Testing

Not applicable. Only documentation is updated.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[justinretzolk]

Had a minor suggestion, but otherwise looks good to me! Thank you for taking the time to raise this @stefanfreitag! 🎉

[justinretzolk]

Since this is an argument, I think we should remove it from the attributes section entirely to be more consistent with other areas of the docs.

[stefanfreitag]

Hi @justinretzolk,

we can do so. One question I have before going that route:

As part of kubernetes_network_config there is service_ipv6_cidr which is Computed: true.
Is this maybe the reason why kubernetes_network_config block is listed under the Attributes section?

(rephrased: How would we need to document service_ipv6_cidr then without mentioning the block under Attributes? - sorry for this possibly stupid question)

[justinretzolk]

This is an interesting one, and I think a great question @stefanfreitag!

From my perspective, the right approach would be to combine the two kubernetes_network_config block definitions (the ones starting at lines 416 and 506 respectively) and then note service_ipv6_cidr as (Read-Only) or (Computed) similar to the way we do for (Optional). I'm not aware of another place in the documentation that we do this, so I'll spend some time looking around to see if we have a precedent here.

[justinretzolk]

In looking, it seems the (Computed) note is an established pattern:

• aws_apigatewayv2_domain_name.domain_name_configuration.hosted_zone_id
• aws_lex_bot_alias.log_settings.resource_prefix

Another time where I wish we were generating all of the docs, but alas 🙂

[stefanfreitag]

I introduced (Computed) and applied our approach on kubernetes_network_config also on vpc_config to be consistent in the document.

[justinretzolk]

Looks good to me! Thanks again for taking care of this! I'll get it merged once the checks go green 🚀

[github-actions]

This functionality has been released in v5.87.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!