Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #50

Merged
merged 8 commits into from
Oct 7, 2020
Merged

Cleanup #50

merged 8 commits into from
Oct 7, 2020

Conversation

paultyng
Copy link
Contributor

@paultyng paultyng commented Oct 6, 2020

  • Rework structure for release
  • Add doc generation

@paultyng paultyng requested a review from malnick October 6, 2020 23:01
@paultyng
Copy link
Contributor Author

paultyng commented Oct 6, 2020

Due to the doc generation it surfaced some undocumented schema, also I think some of the examples are a little out of sync with the schema, now that they are files on disk though probably easier to run terraform validate.

@paultyng
Copy link
Contributor Author

paultyng commented Oct 6, 2020

I can rebase #46 on this if you want to add it in to the generated version.

malnick
malnick approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@malnick malnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment regarding the docs/index.html, otherwise 👍

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
@malnick malnick merged commit 8bb38f1 into main Oct 7, 2020
@malnick malnick deleted the cleanup branch October 7, 2020 00:34
malnick added a commit that referenced this pull request Oct 7, 2020
@malnick
Revert "Cleanup (#50)"
4370a8e 
This reverts commit 8bb38f1.
@malnick malnick mentioned this pull request Oct 7, 2020
Closed
@jefferai jefferai mentioned this pull request Oct 7, 2020
Merged
@paultyng paultyng restored the cleanup branch October 7, 2020 13:14
@paultyng paultyng deleted the cleanup branch October 7, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malnick malnick malnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paultyng @malnick