Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for new Instance Settings resource and a test into a beta provider. #6615

Conversation

modular-magician
Copy link
Collaborator

Background :

Instance Settings is a new GCE compute zonal resource. They are centralized configuration parameters that allow users to configure the default values for specific VM parameters that are normally set using GCE instance API methods. This is a singleton resource (i.e always exists with project and supports only PATCH API).

fixes hashicorp/terraform-provider-google#15748

Changes include:

  1. Added a new InstanceSettings mmv1 resource google_compute_instance_settings.
  2. Added a mmv1 resource basic test, update test.
  3. Tested locally with TF_LOG=DEBUG make testacc TEST=./google-beta/services/compute TESTARGS='-run=TestAccComputeInstanceSettings_instanceSettingsBasicExample'

Release Note Template for Downstream PRs (will be copied)

`google_compute_instance_settings`

Derived from GoogleCloudPlatform/magic-modules#9313

…eta provider. (#9313)

[upstream:f218e989981c0ff81605d43e2095564edbc7116f]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 6029649 into hashicorp:main Nov 8, 2023
2 checks passed
@modular-magician modular-magician deleted the downstream-pr-f218e989981c0ff81605d43e2095564edbc7116f branch November 16, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for InstanceSettings resource in GCE
1 participant