This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
Add proxy argument #102
Merged
Add proxy argument #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
barryib
force-pushed
the
tba-add-proxy-argument
branch
from
6d9dfa1 to
6c526f9
Compare
barryib
changed the title
|
Any chance to see this reviewed ? |
|
Hi @barryib, Thanks for your contribution. I'll take a look at this today or tomorrow. |
barryib
force-pushed
the
tba-add-proxy-argument
branch
from
87cb6d0 to
24cb978
Compare
|
Hi davidji99 Did you get chance to take a look ? |
davidji99
reviewed
Nov 5, 2019
Sorry for the delay. Had one question and a suggestion. |
davidji99
approved these changes
Nov 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add
proxyargument to the provider.Resolves #101