testing: Update acceptance tests to use new statecheck package and value comparers
#599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvalle
commented
Aug 7, 2024
austinvalle
commented
Aug 7, 2024
austinvalle
commented
Aug 7, 2024
| resource.TestCheckNoResourceAttr("random_password.default", "numeric"), | ||
| beforeUpgradeStateChecks: []statecheck.StateCheck{ | ||
| statecheck.ExpectKnownValue("random_password.default", tfjsonpath.New("number"), knownvalue.Bool(true)), | ||
| randomtest.ExpectNoAttribute("random_password.default", tfjsonpath.New("numeric")), |
There was a problem hiding this comment.
A fun (and expected) quirk of our new state checks are that they will recognize if an attribute doesn't exist and fail, so certain usages of resource.TestCheckNoResourceAttr will not be able to be replaced by statecheck.ExpectKnownValue with a knownvalue.Null()
I'm not sure how common it is to check for an attribute not existing, but if it's common we can move the ExpectNoAttribute into the terraform-plugin-testing Go module
SBGoods
approved these changes
Aug 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: hashicorp/terraform-plugin-testing#295, hashicorp/terraform-plugin-testing#266
With this refactor, all of the assertions should be equivalent except for a few where I made the test assertions more restrictive/exact. Let me know if I missed anything!