Skip to content

Recognize tf query files #36929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 15, 2025
Merged

Recognize tf query files #36929

merged 13 commits into from
May 15, 2025

Conversation

dsa0x
Copy link
Member

@dsa0x dsa0x commented Apr 28, 2025 •
edited
Loading

Fixes #

Target Release

1.14.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dsa0x dsa0x added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Apr 28, 2025
@dsa0x dsa0x force-pushed the sams/tfquery branch 2 times, most recently from ebaed4c to 4703686 Compare April 28, 2025 15:34
@dsa0x dsa0x marked this pull request as ready for review May 7, 2025 10:51
@dsa0x dsa0x requested a review from a team as a code owner May 7, 2025 10:51
@dsa0x dsa0x changed the base branch from f-tf-search to main May 13, 2025 15:39
jbardin
jbardin reviewed May 13, 2025
View reviewed changes
Copy link
Member

@jbardin jbardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also add some test cases where tfquery and normal configs are intermingled, to make sure parsing never interferes when a config is being used for both.

@dsa0x dsa0x requested a review from jbardin May 13, 2025 18:03
jbardin
jbardin previously approved these changes May 13, 2025
View reviewed changes
dbanck
dbanck reviewed May 14, 2025
View reviewed changes
@dsa0x dsa0x requested review from dbanck and jbardin May 14, 2025 11:47
@dsa0x dsa0x merged commit 44eb0c6 into main May 15, 2025
8 checks passed
@dsa0x dsa0x deleted the sams/tfquery branch May 15, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbardin jbardin jbardin approved these changes

@dbanck dbanck Awaiting requested review from dbanck

Assignees
No one assigned
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsa0x @jbardin @dbanck