This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
website/docs: Fix markdown links #4793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📄 Content ChecksUpdated: Sat, 10 Jun 2023 21:48:47 GMT Found 5 error(s)
|
| Position | Description | Rule |
|---|---|---|
124:1-124:49 |
Unexpected product-relative link: /docs/waypoint-hcl/build. Ensure that relative links are fully-qualified Developer paths: /{productSlug}/docs/waypoint-hcl/build |
ensure-valid-link-format |
125:1-125:52 |
Unexpected product-relative link: /docs/waypoint-hcl/deploy. Ensure that relative links are fully-qualified Developer paths: /{productSlug}/docs/waypoint-hcl/deploy |
ensure-valid-link-format |
126:1-126:55 |
Unexpected product-relative link: /docs/waypoint-hcl/release. Ensure that relative links are fully-qualified Developer paths: /{productSlug}/docs/waypoint-hcl/release |
ensure-valid-link-format |
127:1-127:52 |
Unexpected product-relative link: /docs/waypoint-hcl/runner. Ensure that relative links are fully-qualified Developer paths: /{productSlug}/docs/waypoint-hcl/runner |
ensure-valid-link-format |
128:1-128:43 |
Unexpected product-relative link: /docs/waypoint-hcl/url. Ensure that relative links are fully-qualified Developer paths: /{productSlug}/docs/waypoint-hcl/url |
ensure-valid-link-format |
anGie44
reviewed
Aug 17, 2023
Comment on lines
+124
to
+128
| [build]: /docs/waypoint-hcl/build 'Build Stanza' | ||
| [deploy]: /docs/waypoint-hcl/deploy 'Deploy Stanza' | ||
| [release]: /docs/waypoint-hcl/release 'Release Stanza' | ||
| [runner]: /docs/waypoint-hcl/runner 'Runner Stanza' | ||
| [url]: /docs/waypoint-hcl/url 'url Stanza' |
There was a problem hiding this comment.
Wow ran into this today, ty! Just a a bystander note (not a reviewer), i think the links need to have "/waypoint" prepended i.e.
Suggested change
| [build]: /docs/waypoint-hcl/build 'Build Stanza' | |
| [deploy]: /docs/waypoint-hcl/deploy 'Deploy Stanza' | |
| [release]: /docs/waypoint-hcl/release 'Release Stanza' | |
| [runner]: /docs/waypoint-hcl/runner 'Runner Stanza' | |
| [url]: /docs/waypoint-hcl/url 'url Stanza' | |
| [build]: /waypoint/docs/waypoint-hcl/build 'Build Stanza' | |
| [deploy]: /waypoint/docs/waypoint-hcl/deploy 'Deploy Stanza' | |
| [release]: /waypoint/docs/waypoint-hcl/release 'Release Stanza' | |
| [runner]: /waypoint/docs/waypoint-hcl/runner 'Runner Stanza' | |
| [url]: /waypoint/docs/waypoint-hcl/url 'url Stanza' |
to make the content checks happy 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix reference-style links in app stanza description.