Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Backport of update ecr-pull to support doing entrypoint injection into release/0.11.x #4853

Conversation

hc-github-team-waypoint
Copy link
Collaborator

Backport

This PR is auto-generated from #4847 to be assessed for backporting due to the inclusion of the label backport/0.11.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@izaaklauer
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/waypoint/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


This PR makes it so ecr-pull can be used the same way docker-pull can to inject the waypoint entrypoint. Currently this is non-passive because it keeps the same default as docker-pull which will inject the entrypoint. disabling the entrypoint injection keeps the previous behavior and does not require the docker or kankio builder (as before)


Overview of commits

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@izaaklauer
Copy link
Contributor

Closed in favor of #4858

@izaaklauer izaaklauer closed this Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants