This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Add support for project-level events #4861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to enable "project-level" events. Before this commit, Events could only be used at the "app-level".
| @@ -845,7 +849,12 @@ message UI { | |||
| uint64 deployment_sequence = 6; | |||
| } | |||
|
|
|||
| message EventAddOn { | |||
| message EventAddOnCreated { | |||
There was a problem hiding this comment.
I'm curious what the rationale is for splitting out EventAddonCreated and EventAddonDestroyed into 2 separate events. My first instinct is what you had initially (EventAddOn), with the created/destroyed type being inside EventData.
There was a problem hiding this comment.
@andrew-hashicorp I think that your suggestion is a good stylistic suggestion on how "events" should be designed. Another example that could fit this model (in the future) is the "deployment" event, which could either be the creation or destruction of a deployment.
I am merging this PR to the non-main upstream branch in its current state, but will follow-up with a PR containing this suggested change as well.
evanphx
approved these changes
Aug 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.