This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Backport of Add guards against nil derefernce panics in job/task CLI commands into release/0.11.x #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-waypoint
force-pushed
the
backport/job_guard_nil_app/especially-certain-eel
branch
from
c2cfd25
to
1f8064a
Compare
hc-github-team-waypoint
deleted the
backport/job_guard_nil_app/especially-certain-eel
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #4867 to be assessed for backporting due to the inclusion of the label backport/0.11.x.
The below text is copied from the body of the original PR.
If a project has been destroyed, both the project and app are removed from the state. Jobs and Tasks still reference things by application ID and if null in the state are being set to nil in the gRPC response.
In this PR we simply guard against nil values when outputting to the CLI. We assume a nil Project/Application means the project/application was deleted. If we use
""instead then these columns will simply not show in the output, so we felt it should be explicit that those projects/applications have been deleted.Overview of commits