with-based functionality #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow for a more "standard" bracket to be imported.
Not really a streaming function, but useful in the withXXX paradigm.
Just for completeness.
To make it easier to only have to import the module from this library rather than also needing to bring in postgresql-simple.
|
Sorry for having this languish. There's quite a lot going on, so I'll try and put some time aside to review. |
|
If you're OK with the functionality, I'll add a variant based upon |
|
As well as, or instead? I feel the API of this package is growing rather surprisingly large, which is mostly the bit I want to think about. |
|
In addition to, in a separate module. Even the functions in this PR could be in a separate module if you'd prefer to keep the surface of each module small. |
|
I'll have a think. Those are valid options. |
|
In the interest of reviving this PR, I can think of the following options:
What is your preference? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of the discussion in michaelt/streaming#23 this adds with-style continuation parsing style variants of all functions except
copyIn, as well as some convenience functions/re-exports.