Get rid of template preprocessing #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of preprocessing an outer layer of CPP when building Alex, just always produce code that uses CPP. Combined with from-source bootstrapping, this means Alex an have a perfectly bog standard build system, with Makefiles and extra steps strictly optional. I gather Hugs, and possibly other Haskell implementations, out of the box doesn't support CPP, but I don't want this to stop us. Those can just manually run CPP on the generated code first.
Ericson2314
force-pushed
the
no-preprocess-templates
branch
from
b1c4e56 to
8360bbe
Compare
|
LGTM |
|
Thanks @simonmar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of preprocessing an outer layer of CPP when building Alex, just
always produce code that uses CPP. Combined with from-source
bootstrapping, this means Alex an have a perfectly bog standard build
system, with Makefiles and extra steps strictly optional.
I gather Hugs, and possibly other Haskell implementations, out of the
box doesn't support CPP, but I don't want this to stop us. Those can
just manually run CPP on the generated code first.
Same idea as haskell/happy#179.