Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record Git revision in devel builds #10541

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geekosaur
Copy link
Collaborator

cabal --version in such builds will include the Git commit and branch (if not master).

I've already been informed that this is not appropriate, but maybe someone will find something worth salvaging in it. It is also incomplete insofar as it needs a changelog entry and such (but probably not a test).

Consider this my last submission.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

`cabal --version` in such builds will include the Git commit and
branch (if not `master`).
@geekosaur
Copy link
Collaborator Author

hilfy «cabal:git-revs@39b5fae1a$» Z$ $(cabal list-bin cabal) --version
cabal-install version 3.15.0.0 (commit 39b5fae on git-revs, Sun Nov 10 03:13:17 2024 -0500)
compiled using version 3.15.0.0 of the Cabal library (in-tree)

I did come up with a reasonable situation where Cabal could have different git information than cabal-install, so I added that back in. (Building a pre-release cabal-install package with a pre-release ghc, not in-tree, such that ghc's libraries/cabal is used.) I did simplify the output if it's the same, as shown above.

@ulysses4ever
Copy link
Collaborator

Hey @geekosaur! Do you have any plans around this one? It'd be great to have the SHA one way or another...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal --version on a non-release build should include a Git commit
2 participants