Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS tests: Quieter output #10587

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

9999years
Copy link
Collaborator

This prevents the tests from spamming lots of output, making it easier to watch them as they run.

Before:

      check VCS test framework:                                                 10% warning: refname 'd6077f476a7c17fe8528e62688a19cc5bddbfbdc' is ambiguous.
Git normally never creates a ref that ends with 40 hex characters
because it will be ignored when you just specify 40-hex. These refs
may be created by mistake. For example,

  git switch -c $br $(git rev-parse ...)

where "$br" is somehow empty and a 40-hex ref is created. Please
examine these refs and maybe delete them. Turn this message off by
running "git config advice.objectNameWarning false"
rm 'file/C'
Cloning into '/private/var/folders/z5/fclwwdms3r1gq4k4p3pkvvc00000gn/T/vcstest-64269/src/file/C'...
done.
Submodule path 'file/C': checked out '210af0166ade8b306b425782305b8c6e910aa2c0'
Cloning into '/private/var/folders/z5/fclwwdms3r1gq4k4p3pkvvc00000gn/T/vcstest-64267/src/file/D'...
done.
Submodule path 'file/D': checked out '95b580ef06aec22b38f6e0a5c3305d5c293669a0'
branch 'branch_D' set up to track 'main'.
branch 'branch_C' set up to track 'main'.
rm 'file/C'
Cloning into '/private/var/folders/z5/fclwwdms3r1gq4k4p3pkvvc00000gn/T/vcstest-64269/src/file/C'...
done.
rm 'file/D'
Submodule path 'file/C': checked out 'ee47ffdda57945d841bc7f59ea72a78043c4ac02'
Cloning into '/private/var/folders/z5/fclwwdms3r1gq4k4p3pkvvc00000gn/T/vcstest-64267/src/file/D'...
done.
Submodule path 'file/D': checked out '23d9b5f39ae56c429dd9498d42338d27ea4e6545'

After:

  UnitTests.Distribution.Client.VCS
    git
      check VCS test framework:                                                 warning: --depth is ignored in local clones; use file:// instead.
warning: refname 'fbfe708a98c79a7c97e83609275b0f604f26e18b' is ambiguous.
Git normally never creates a ref that ends with 40 hex characters
because it will be ignored when you just specify 40-hex. These refs
may be created by mistake. For example,

  git switch -c $br $(git rev-parse ...)

where "$br" is somehow empty and a 40-hex ref is created. Please
examine these refs and maybe delete them. Turn this message off by
running "git config advice.objectNameWarning false"
warning: --depth is ignored in local clones; use file:// instead.
warning: --depth is ignored in local clones; use file:// instead.
warning: refname 'dc2abca0fd032b5cdd8904e6931679b4d6e6b25b' is ambiguous.
Git normally never creates a ref that ends with 40 hex characters
because it will be ignored when you just specify 40-hex. These refs
may be created by mistake. For example,

  git switch -c $br $(git rev-parse ...)

where "$br" is somehow empty and a 40-hex ref is created. Please
examine these refs and maybe delete them. Turn this message off by
running "git config advice.objectNameWarning false"

These warnings require semantic changes which will come in a separate PR (#10586).

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Contributor

mergify bot commented Nov 22, 2024

⚠️ The sha of the head commit of this PR conflicts with #10586. Mergify cannot evaluate rules on this PR. ⚠️

This prevents the tests from spamming lots of output, making it easier
to watch them as they run.

Before:

```
      check VCS test framework:                                                 10% warning: refname 'd6077f476a7c17fe8528e62688a19cc5bddbfbdc' is ambiguous.
Git normally never creates a ref that ends with 40 hex characters
because it will be ignored when you just specify 40-hex. These refs
may be created by mistake. For example,

  git switch -c $br $(git rev-parse ...)

where "$br" is somehow empty and a 40-hex ref is created. Please
examine these refs and maybe delete them. Turn this message off by
running "git config advice.objectNameWarning false"
rm 'file/C'
Cloning into '/private/var/folders/z5/fclwwdms3r1gq4k4p3pkvvc00000gn/T/vcstest-64269/src/file/C'...
done.
Submodule path 'file/C': checked out '210af0166ade8b306b425782305b8c6e910aa2c0'
Cloning into '/private/var/folders/z5/fclwwdms3r1gq4k4p3pkvvc00000gn/T/vcstest-64267/src/file/D'...
done.
Submodule path 'file/D': checked out '95b580ef06aec22b38f6e0a5c3305d5c293669a0'
branch 'branch_D' set up to track 'main'.
branch 'branch_C' set up to track 'main'.
rm 'file/C'
Cloning into '/private/var/folders/z5/fclwwdms3r1gq4k4p3pkvvc00000gn/T/vcstest-64269/src/file/C'...
done.
rm 'file/D'
Submodule path 'file/C': checked out 'ee47ffdda57945d841bc7f59ea72a78043c4ac02'
Cloning into '/private/var/folders/z5/fclwwdms3r1gq4k4p3pkvvc00000gn/T/vcstest-64267/src/file/D'...
done.
Submodule path 'file/D': checked out '23d9b5f39ae56c429dd9498d42338d27ea4e6545'
```

After:

```
  UnitTests.Distribution.Client.VCS
    git
      check VCS test framework:                                                 warning: --depth is ignored in local clones; use file:// instead.
warning: refname 'fbfe708a98c79a7c97e83609275b0f604f26e18b' is ambiguous.
Git normally never creates a ref that ends with 40 hex characters
because it will be ignored when you just specify 40-hex. These refs
may be created by mistake. For example,

  git switch -c $br $(git rev-parse ...)

where "$br" is somehow empty and a 40-hex ref is created. Please
examine these refs and maybe delete them. Turn this message off by
running "git config advice.objectNameWarning false"
warning: --depth is ignored in local clones; use file:// instead.
warning: --depth is ignored in local clones; use file:// instead.
warning: refname 'dc2abca0fd032b5cdd8904e6931679b4d6e6b25b' is ambiguous.
Git normally never creates a ref that ends with 40 hex characters
because it will be ignored when you just specify 40-hex. These refs
may be created by mistake. For example,

  git switch -c $br $(git rev-parse ...)

where "$br" is somehow empty and a 40-hex ref is created. Please
examine these refs and maybe delete them. Turn this message off by
running "git config advice.objectNameWarning false"
```

These warnings require semantic changes which will come in a separate
PR.
@9999years 9999years marked this pull request as ready for review November 22, 2024 21:08
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a slight change in cabal-install proper, which, strictly speaking, should be documented in a changelog

@9999years
Copy link
Collaborator Author

Done, thanks for the changelog entry nudge @ulysses4ever

@ulysses4ever
Copy link
Collaborator

Sure thing!

@9999years 9999years added the merge me Tell Mergify Bot to merge label Nov 26, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants