VCS tests: Make smaller Arbitrary repositories to speed up long-tests 4.2x
#10588
+54
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
force-pushed
the
vcs-arbitrary
branch
from
9654d35
to
42bfdd4
Compare
9999years
changed the title
Arbitrary repositoriesArbitrary repositories to speed up long-tests 4.2x
5 tasks
geekosaur
approved these changes
Nov 22, 2024
ulysses4ever
approved these changes
Nov 23, 2024
mergify
bot
added
ready and waiting
The `Arbitrary` repo recipes can get quite large due to nesting: - `RepoRecipes` contain a number of groups (`TaggedCommits` or `BranchCommits`). - Groups contain a number of `Commit`s. - Commits contain a number of operations (`FileUpdate` or `SubmoduleAdd`). There's also another wrinkle in that `SubmoduleAdd`s contain a `Commit` themselves, so square the `operationsPerCommit` number! Then, a rough upper bound of the number of `git` calls required for an arbitrary `RepoRecipe` is `groupsPerRecipe * commitsPerGroup * operationsPerCommit^2`. The original implementation of these instances, which chose reasonable-sounding size parameters of 5-15, led to a maximum of 1875 operations per test case! No wonder they took so long! In my tests, this change reduces the time of running the `long-tests` suite from 429 seconds to 102 seconds (a 4.2x speedup).
Mikolaj
force-pushed
the
vcs-arbitrary
branch
from
42bfdd4
to
351ebb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Arbitraryrepo recipes can get quite large due to nesting:RepoRecipescontain a number of groups (TaggedCommitsorBranchCommits).Commits.FileUpdateorSubmoduleAdd).There's also another wrinkle in that
SubmoduleAdds contain aCommitthemselves, so square theoperationsPerCommitnumber!Then, a rough upper bound of the number of
gitcalls required for an arbitraryRepoRecipeisgroupsPerRecipe * commitsPerGroup * operationsPerCommit^2.The original implementation of these instances, which chose reasonable-sounding size parameters of 5-15, led to a maximum of 1875 operations per test case! No wonder they took so long!
In my tests, this change reduces the time of running the
long-testssuite from 429 seconds to 102 seconds (a 4.2x speedup).