haskell-cabal: fix (comment-dwim) by correcting comment-start-skip #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-Angel
changed the title
Prior to this commit using (comment-dwim) over a comment in .cabal
file that doesn't start at the beginning of a line resulted in it
adding even more comments. E.g. this:
-- comment not at the beginning of a line
resulted in:
-- -- comment not at the beginning of a line
This is because `comment-start-skip` was including whitespace that
isn't part of the comment syntax. Fix this by only limiting the regexp
to the comment part.
The resulting regexp is basically same as the one in haskell-mode,
barring that that one also takes into account `{-` comment starter,
which isn't a thing in .cabal files.
Fixes: haskell#1743
Hi-Angel
force-pushed
the
fix-cabal-uncomment
branch
from
eb65529 to
497811f
Compare
Hi-Angel
changed the title
|
Just realized there was a bugreport for this, added to "fixes". |
|
Nice, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit using (comment-dwim) over a comment in .cabal file that doesn't start at the beginning of a line resulted in it adding even more comments. E.g. this:
resulted in:
This is because
comment-start-skipwas including whitespace that isn't part of the comment syntax. Fix this by only limiting the regexp to the comment part.The resulting regexp is basically same as the one in haskell-mode, barring that that one also takes into account
{-comment starter, which isn't a thing in .cabal files.Fixes: #1743