Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add query command to check wheter a package/version is affected #121

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

blackheaven
Copy link
Collaborator

@blackheaven blackheaven commented Sep 23, 2023

hsec-tools

  • Previous advisories are still valid

TODO

  • Add tests
  • Add command helper

@blackheaven blackheaven force-pushed the query/introduction branch 2 times, most recently from 87f527b to 1b6d9b7 Compare September 27, 2023 16:50
@blackheaven
Copy link
Collaborator Author

good to go

@mmhat
Copy link
Contributor

mmhat commented Sep 30, 2023

Hi, I implemented some suggestions in a PR against this PR: blackheaven#2
As explained there, the original motivation was a function to query advisories for a specific version, but I got a bit carried away and changed some more stuff. As mentioned there, feel free to use it as a whole or cherry-pick the parts you like. While some of the changes are not really important there is one I'd like to see included here: IMHO listAffectedBy (or listVersionRangeAffectedBy in my PR - I renamed it) should not use exitFailure as it makes it more difficult to work with this function if you use hsec-tools as library.

@blackheaven blackheaven merged commit 09bb965 into haskell:main Oct 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants