Add tests for munstream #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
approved these changes
Sep 16, 2021
It turns out we don't exercise munstream in the test suite at all. (Easy check is to replace definition with undefined and run test) This is to check equivalence of all variants. This is necessary for any changes to unstream machinery. Such as ones that discussed in haskell#301, haskell#388, haskell#406
Shimuuar
force-pushed
the
munstream-test
branch
from
741b810 to
d501245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on unstreaming machinery (See #301, #388, #406 for context) I found out that we don't test
unstreamat all. One could replace its definition with undefined and tests will still pass. This PR fixes this situation by adding tests thatunstream,vunstreamandunstreamRproduce identical results.There're few cleanups for the test suite.