Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two more ways of authentication for the OAuth 1.0a workflow #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsantos17
Copy link
Contributor

This pull request is a superset of #45. I'm not sure if the changes here make sense to add to Wreq. This adds three more authentication options:

  1. The first one to make requests once the user has API keys (consumer token, consumer secret) and access tokens for a resource-owner.
  2. The second one to ask a service provider to generate temporary tokens so the client can request permission from the resource-owner using the redirection workflow common in OAuth 1.0a.
  3. A third one to exchange temporary tokens and an oauth_verifier token for access tokens in order to finish authentication.

This effectively makes Wreq capable of conducting the whole three-legged authentication required by a service provider such as Twitter.

Only OAuth 1.0a is supported, mainly because I'm not sure how to support OAuth 1.0 without adding three more constructors to the Auth type.

@jsantos17 jsantos17 changed the title Add temporary token request Add two more ways of authentication for the OAuth 1.0a workflow Dec 28, 2014
@bos
Copy link
Collaborator

bos commented Dec 22, 2015

I applied #45, which has many conflicts with this PR. How would you like to proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants