fix(demo): move step_1 success tracking after the frontend auth (Nang…

…oHQ#1961)

## Describe your changes

Fixes NAN-700

We realised the tracking of Step1 in the backend was suboptimal. At this
step we deploy and immediatly trigger a GitHub oauth. In the frontend
the event is correctly reported because it encapsulates both sub-steps
but in the backend the success was reported too early

- Track step1_success only when we actually oauthed to GitHub

packages/server/lib/controllers/onboarding.controller.ts

@@ -85,7 +85,6 @@ class OnboardingController {
                 await createOnboardingProvider({ envId: environment.id });
             }
 
-            void analytics.track(AnalyticsTypes.DEMO_1_SUCCESS, account.id, { user_id: user.id });
             res.status(201).json({
                 id: onboardingId
             });
@@ -345,6 +344,11 @@ class OnboardingController {
             if (progress === 3 || progress === 6) {
                 void analytics.track(AnalyticsTypes[`DEMO_${progress}`], account.id, { user_id: user.id });
             }
+            if (progress === 1) {
+                // Step 1 is actually deploy+frontend auth
+                // Frontend is in a different API so we can't instrument it on the backend so we assume if we progress then step 1 was a success
+                void analytics.track(AnalyticsTypes.DEMO_1_SUCCESS, account.id, { user_id: user.id });
+            }
 
             res.status(200).json({
                 success: true