Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add functionality to trigger HA events #235

Closed
wants to merge 1 commit into from

Conversation

Alwinator
Copy link

Proposed Changes

Speakers usually consume a lot of energy. So, I plugged my speakers into a smart plug and turned them on or off based on the source of my Spotify account.

However, this only works for my Spotify and has a delay of around 20 seconds.

So, I had the idea to integrate Spotify-connect more into HA. Based on the logs it will trigger events for new connections, new songs, and other events.

In this way, you can build automations based on Spotify-connect.

I am not done yet, but I still wanted to create a PR, so you can maybe guide me in which direction this should go. However, the basic functionality is implemented.

@frenck
Copy link
Member

frenck commented Aug 11, 2023

So, I had the idea to integrate Spotify-connect more into HA.

That is not an add-on responsibility, that is a responsibility of an add-on. It sounds like you are building something in the wrong place?

../Frenck

@Alwinator
Copy link
Author

@frenck Thanks! :)

That is not an add-on responsibility, that is a responsibility of an add-on

I am not sure if I understand what you want to say. Do you mean instead of integrating it into your add-on I should build a separate add-on that fetches you logs?

It sounds like you are building something in the wrong place?

Which place would you as an expert recommend, when I want to build my kind of automation?

@Alwinator
Copy link
Author

@frenck :)

@frenck
Copy link
Member

frenck commented Aug 25, 2023

Sorry missed your response.

This is not an integration. Integrations integrate with Home Assistant. Add-ons provides services; services integrations could integrate with.

This PR isn't valid and in the wrong location. If you want to integrate things with Home Assistant, please build integrations.

../Frenck

@frenck frenck closed this Aug 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants