-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add librespot_options
option
#262
Add librespot_options
option
#262
Conversation
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
WalkthroughThe recent updates introduce a new configuration option, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- spotify/DOCS.md (3 hunks)
- spotify/config.yaml (1 hunks)
- spotify/rootfs/etc/services.d/spotifyd/run (2 hunks)
- spotify/translations/en.yaml (1 hunks)
Additional comments not posted (5)
spotify/config.yaml (1)
24-24
: Addition oflibrespot_options
is appropriate.The inclusion of
librespot_options
as an optional string enhances configurability without affecting existing functionality.spotify/translations/en.yaml (1)
26-30
: New translation entry forlibrespot_options
is well-structured.The entry provides a clear name and description, enhancing user understanding and providing a helpful link to external documentation.
spotify/rootfs/etc/services.d/spotifyd/run (1)
Line range hint
11-48
:
Inclusion oflibrespot_options
in the script is well-implemented.The script correctly checks for and applies additional command-line options, enhancing flexibility without altering existing behavior.
spotify/DOCS.md (2)
40-40
: Ensure clarity in example configuration.The example configuration line for
librespot_options
is clear and provides a practical example. Ensure that users understand that this is an optional field and can be customized as needed.
92-94
: Clarify thelibrespot_options
description.The description of the
librespot_options
is concise and directs users to the external documentation. Ensure that the link to the librespot documentation is correct and accessible.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
This PR adds support for adding arbitrary additional librespot options. It's completely opt-in and does not change any existing behaviour
Some users may wish to change librespot settings, and many won't have the time to fluff around cloning repos and adding options to suit their use case. This is a minimal effort way to enable advanced users to use any option in while using the addon.
See the librespot documentation for more information about other options
To test this option:
--volume-ctrl fixed --normalisation-pregain -9
Sample output
Summary by CodeRabbit
New Features
librespot_options
, allowing users to specify additional parameters for the Librespot service in HomeAssistant.librespot_options
for better user awareness and guidance.Enhancements
Translations
librespot_options
feature.