Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments edits #715

Merged
merged 7 commits into from
Oct 21, 2024
Merged

comments edits #715

merged 7 commits into from
Oct 21, 2024

Conversation

rahulagarwal13
Copy link
Contributor

Description 📝

Quick Links 🚀

Assertion Tests 🤖

@hasura-bot
Copy link
Contributor

Error testing the assertions. Check the logs.

@hasura-bot
Copy link
Contributor

@rahulagarwal13 Thanks for your PR! I've assigned @robertjdominguez to review it.

@hasura-bot
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 29%, saving 111.63 KB.

Filename Before After Improvement Visual comparison
static/img/get-started/comments_graphql.png 249.57 KB 168.64 KB -32.4% View diff
static/img/get-started/comments_supergraph.png 135.15 KB 104.45 KB -22.7% View diff

190 images did not require optimisation.

Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2024

Deploying v3-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4686bf2
Status:⚡️  Build in progress...

View logs

@hasura-bot
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 24%, saving 188.31 KB.

Filename Before After Improvement Visual comparison
static/img/get-started/comments_builds.png 343.59 KB 269.06 KB -21.7% View diff
static/img/get-started/comments_insights.png 276.21 KB 206.16 KB -25.4% View diff
static/img/get-started/comments_notification.png 75.33 KB 53.73 KB -28.7% View diff
static/img/get-started/comments_subgraph.png 89.74 KB 67.61 KB -24.7% View diff

192 images did not require optimisation.

@rahulagarwal13 rahulagarwal13 marked this pull request as ready for review October 18, 2024 21:19
Copy link
Collaborator

@robertjdominguez robertjdominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rahulagarwal13 👍

A few of the screenshots (e.g., Insights and Builds) can be a bit hard to follow due to their "collage-like" arrangement. But, this isn't a blocker. If we have the time, let's follow up with dedicated screenshots and — optionally — use the <Tabs/> component to let users click through the various options.

@robertjdominguez robertjdominguez enabled auto-merge (squash) October 21, 2024 11:57
@robertjdominguez robertjdominguez merged commit 8785a49 into main Oct 21, 2024
4 of 5 checks passed
@robertjdominguez robertjdominguez deleted the rahul/oct17/platformfeatures branch October 21, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants