Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript example to use actually supported types #756

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

daniel-chambers
Copy link
Contributor

@daniel-chambers daniel-chambers commented Oct 31, 2024

Description 📝

The example on the Business Logic -> TypeScript doesn't actually work in the NodeJS connector. The Omit type used in the example is not supported.

This PR fixes the example to use supported types.

Quick Links 🚀

https://daniel-fix-ts-example.v3-docs-eny.pages.dev/business-logic/typescript/#add-a-procedure

@daniel-chambers daniel-chambers self-assigned this Oct 31, 2024
@hasura-bot
Copy link
Contributor

@daniel-chambers Thanks for your PR! I've assigned @seanparkross to review it.

Copy link

cloudflare-workers-and-pages bot commented Oct 31, 2024

Deploying v3-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a7beec
Status:⚡️  Build in progress...

View logs

Copy link
Collaborator

@robertjdominguez robertjdominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @daniel-chambers!

@robertjdominguez robertjdominguez merged commit 729a427 into main Oct 31, 2024
0 of 4 checks passed
@robertjdominguez robertjdominguez deleted the daniel/fix-ts-example branch October 31, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants