Upgrade to ndc-spec v0.1.1. #1
Merged
+591
−454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: - type representations in the models - upgrading the OpenTelemetry SDK - adding a feature switch to support `rustls` instead of `native-tls` - a lot of enhancements to ndc-test
plcplc
reviewed
Mar 26, 2024
| @@ -228,8 +228,11 @@ where | |||
| <Setup::Connector as Connector>::Configuration: Clone, | |||
| <Setup::Connector as Connector>::State: Clone, | |||
| { | |||
| init_tracing(&serve_command.service_name, &serve_command.otlp_endpoint) | |||
| .expect("Unable to initialize tracing"); | |||
| init_tracing( | |||
There was a problem hiding this comment.
What's the rationale for prefering to .as_deref() over & ?
There was a problem hiding this comment.
It transforms Option<String> to Option<&str>.
plcplc
reviewed
Mar 26, 2024
| ndc-client = { git = "http://github.com/hasura/ndc-spec.git", tag = "v0.1.1" } | ||
| ndc-test = { git = "http://github.com/hasura/ndc-spec.git", tag = "v0.1.1", optional = true } | ||
|
|
||
| async-trait = "0.1.79" |
There was a problem hiding this comment.
How do these version upgrades come about? Is it just cargo update or somesuch?
There was a problem hiding this comment.
cargo upgrade. I was upgrading opentelemetry and friends to match ndc-client and figured I might as well do the rest (except for upgrades to the HTTP stack, which are incompatible).
I thought `cargo upgrade` would do this but apparently I needed a `cargo update`.
plcplc
approved these changes
Mar 26, 2024
SamirTalwar
added a commit
to hasura/ndc-postgres
that referenced
this pull request
Mar 26, 2024
See hasura/ndc-sdk-rs#1 for details. I discovered we can specify workspace dependencies, which means the versions only need to go in one place. I am experimenting with this Cargo feature in this changeset. If we like it, we may want to use it for all dependencies.
github-merge-queue bot
pushed a commit
to hasura/ndc-postgres
that referenced
this pull request
Mar 27, 2024
### What This includes: - type representations in the models - upgrading the OpenTelemetry SDK - adding a feature switch to support `rustls` instead of `native-tls` - a lot of enhancements to ndc-test ndc-sdk was upgraded in hasura/ndc-sdk-rs#1. We do not actually specify type representations in this changeset. We will add these in a follow-up change. ### How I discovered we can specify workspace dependencies, which means the versions only need to go in one place. I am experimenting with this Cargo feature in this changeset. If we like it, we may want to use it for all dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
rustlsinstead ofnative-tls