Update-ndc-spec-0.1.3 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitRanque
commented
May 29, 2024
| @@ -1,7 +1,7 @@ | |||
| [workspace] | |||
| resolver = "2" | |||
|
|
|||
| package.version = "0.1.0" | |||
| package.version = "0.1.3" | |||
There was a problem hiding this comment.
Bumped version from 0.1.0 to 0.1.3, to keep the same version number as the corresponding ndc-spec.
Is this a good idea, should we do something else instead? The thinking is having a single number wil be less confusing.
BenoitRanque
commented
May 29, 2024
| @@ -50,13 +50,17 @@ impl Connector for Example { | |||
|
|
|||
| async fn get_capabilities() -> JsonResponse<models::CapabilitiesResponse> { | |||
| models::CapabilitiesResponse { | |||
| version: "0.1.1".into(), | |||
| version: "0.1.3".into(), | |||
There was a problem hiding this comment.
Very unsure about this, I think version is supposed to be the ndc-spec version, is that correct?
BenoitRanque
commented
May 29, 2024
| @@ -84,6 +84,8 @@ struct TestCommand { | |||
| configuration: PathBuf, | |||
| #[arg(long, value_name = "DIRECTORY", env = "HASURA_SNAPSHOTS_DIR")] | |||
| snapshots_dir: Option<PathBuf>, | |||
| #[arg(long, help = "Turn off validations for query responses")] | |||
| no_validate_responses: bool, | |||
There was a problem hiding this comment.
this flag copied from the ndc-test implementation
soupi
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to ndc spec 0.1.3
Note: also updating the sdk version to the same number, is that a good idea?