Initialize state on first request. #31
Merged
+110
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need state to successfully handle some requests, so let's not initialize it until we need it. This wraps the state in a `OnceCell` which is initialized on first use. The `ConnectorSetup` has been split into two to achieve this, because `ParseConfiguration` cannot be made into an object.
danieljharvey
approved these changes
Aug 23, 2024
SamirTalwar
commented
Aug 23, 2024
Comment on lines
-153
to
+152
| configuration_dir: impl AsRef<Path> + Send, | ||
| configuration_dir: &Path, |
There was a problem hiding this comment.
This change allows ConnectorSetup to be "object-safe", which means we can put it in a Box<dyn ConnectorSetup>.
There was a problem hiding this comment.
Aha! How did you find out? was there a clue in the error message?
I suppose this restriction actually makes sense since f(arg: impl T<X>) actually becomes f<Y>(arg: Y) where Y impl T<X>, and if generics are compiled using specialization/erasure rather than passing around a dictionary of trait methods.
There was a problem hiding this comment.
I stared it, thought "worth a try", tried it, and it worked! 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need state to successfully handle some requests, so let's not initialize it until we need it.
With these changes, requests to
/capabilities,/schema, and/healthwill still succeed even if the state cannot be initialized.This wraps the state in a
OnceCellwhich is initialized on first use.This changes the
ConnectorSetupinterface, and as such constitutes a breaking change.