Inline axum-test-helper. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its dependency tree does not agree with us. We can simply reproduce the [`TestClient`][test_client.rs] from the internals of `axum` ourselves (which is what `axum-test-helper` does, too). Our version has even fewer features, because we only need to support `GET` requests. [test_client.rs]: https://github.com/tokio-rs/axum/blob/axum-v0.6.20/axum/src/test_helpers/test_client.rs
SamirTalwar
commented
Aug 23, 2024
| use super::*; | ||
|
|
||
| #[tokio::test] | ||
| async fn capabilities_match_ndc_spec_version() -> Result<()> { |
There was a problem hiding this comment.
This test is pointless, now that ndc_models exports VERSION and we use it in the SDK.
|
Could this be used by other clients of the sdk, like ndc-postgres? |
|
@soupi: Yes, I'd be up for pulling it into a separate crate if we find it useful. |
soupi
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its dependency tree does not agree with us.
We can simply reproduce the
TestClientfrom the internals ofaxumourselves (which is whataxum-test-helperdoes, too).Our version has even fewer features, because we only need to support
GETrequests.