support zipkin b3 propagation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamirTalwar
reviewed
Apr 16, 2024
Comment on lines
+18
to
+19
| Box::new(opentelemetry_sdk::propagation::TraceContextPropagator::new()), | ||
| Box::new(opentelemetry_zipkin::Propagator::new()), |
There was a problem hiding this comment.
Shouldn't the Zipkin one go first?
There was a problem hiding this comment.
No, Zipkin should go last. The composite propagator gets the latest propagation value.
https://github.com/open-telemetry/opentelemetry-rust/blob/2286378632d498ce4b2da109e5aa131b34ae1a8f/opentelemetry/src/propagation/composite.rs#L106
There was a problem hiding this comment.
Well, that is confusing. Thanks for clarifying.
SamirTalwar
approved these changes
Apr 17, 2024
github-merge-queue bot
pushed a commit
to hasura/ndc-postgres
that referenced
this pull request
Apr 17, 2024
### What We'd like to accept B3 trace headers because Google Cloud sometimes messes with W3C headers. ### How The change has already been made in hasura/ndc-sdk-rs#5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connectors should support both W3C and Zipkin B3 propagation. B3 propagation headers priority should be higher because W3C traceparent header is intercepted by Cloud Run service.