feat(v1): new gRPC API endpoints #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grutt
reviewed
Mar 18, 2025
|
|
||
| message SleepMatchCondition { | ||
| BaseMatchCondition base = 1; | ||
| string sleep_for = 2; // a duration string indicating how long to sleep |
There was a problem hiding this comment.
just curious what resolution can we support (i.e. ms?)
There was a problem hiding this comment.
Go duration string: Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h"
grutt
reviewed
Mar 18, 2025
| message CreateTaskOpts { | ||
| string readable_id = 1; // (required) the task name | ||
| string action = 2; // (required) the task action id | ||
| string timeout = 3; // (optional) the task timeout |
There was a problem hiding this comment.
is schedule time out not on the task now?
There was a problem hiding this comment.
nice catch, it is
There was a problem hiding this comment.
maybe schedule_timeout on the workflow should be changed to default_schedule timeout
also priority is task level
abelanger5
commented
Mar 20, 2025
| } | ||
|
|
||
| message BaseMatchCondition { | ||
| string event_key = 1; |
abelanger5
commented
Mar 20, 2025
| string readable_data_key = 2; | ||
| Action action = 3; | ||
| string or_group_id = 4; // a UUID defining the OR group for this condition | ||
| string expression = 5; |
abelanger5
commented
Mar 20, 2025
|
|
||
| enum Action { | ||
| CREATE = 0; | ||
| QUEUE = 1; |
There was a problem hiding this comment.
Document: QUEUE, CANCEL, SKIP relevant for task triggers, CREATE relevant for signals
mrkaye97
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds endpoints for durable event listeners and more dynamic DAG triggering/skipping.
Type of change