Merge pull request #176 from hathitrust/173_dedicated_version_module

Addresses #173 Move our $VERSION from cgi/CRMS.pm to a dedicated file

Makefile.PL

@@ -6,6 +6,6 @@ my ($mm) = $ExtUtils::MakeMaker::VERSION =~ /^([^_]+)/;
 
 WriteMakefile(
   NAME         => 'CRMS',
-  VERSION_FROM => 'cgi/CRMS.pm',
+  VERSION_FROM => 'lib/CRMS/Version.pm',
   test => {RECURSIVE_TEST_FILES => 1}
 );

cgi/CRMS.pm

@@ -28,6 +28,7 @@ use Unicode::Normalize;
 use XML::LibXML;
 
 use CRMS::Config;
+use CRMS::Version;
 use Utilities;
 
 binmode(STDOUT, ':encoding(UTF-8)');
@@ -66,10 +67,8 @@ sub new
   return $self;
 }
 
-our $VERSION = '8.6.4';
-sub Version
-{
-  return $VERSION;
+sub Version {
+  return $CRMS::Version::VERSION;
 }
 
 # First, try to establish the identity of the user as represented in the users table.

lib/CRMS/Version.pm

@@ -0,0 +1,8 @@
+package CRMS::Version;
+
+use strict;
+use warnings;
+
+our $VERSION = '8.6.4';
+
+1;

t/CRMS.t

@@ -14,6 +14,10 @@ my $cgi = CGI->new();
 my $crms = CRMS->new('cgi' => $cgi, 'verbose' => 0);
 ok(defined $crms, 'CRMS object created');
 
+subtest '#Version' => sub {
+  ok($crms->Version);
+};
+
 subtest 'CRMS::MoveToHathitrustFiles' => sub {
   my $tempdir = File::Temp::tempdir(CLEANUP => 1);
   my $save_hathitrust_files_directory = $ENV{'CRMS_HATHITRUST_FILES_DIRECTORY'};