Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-628 Run CRMS report of monographs with known renewal ending in ‘56 #126

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

moseshll
Copy link
Collaborator

@moseshll moseshll commented Jan 15, 2024

  • Add bin/pdd_renewal_report.pl based on a series of one-off snippets from previous years.
  • Will be documented in Confluence as part of technical staff PDD instructions.

Reviewer:
This is a relatively straightforward "do a DB query and dump a TSV" kind of script. A quick scan of the usage summary and a scan of the relevant Confluence doc (https://hathitrust.atlassian.net/wiki/x/LAAjo) should suffice. (At the moment the instructions for this script are at the very end of the document.)

- Add bin/pdd_renewal_report.pl based on a series of one-off snippets from previous years.
- Will be documented in Confluence as part of technical staff PDD instructions.
@moseshll moseshll requested a review from mwarin January 15, 2024 21:50
Copy link

@mwarin mwarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clean perl, makes sense and isn't trying to do too many things at once. Read but not run. Minor nitpicks in comments. Approve.

@moseshll moseshll merged commit 7593832 into main Jan 16, 2024
1 check passed
@moseshll moseshll deleted the DEV-628_PDD_renewal_report branch January 16, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants