Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTO-184 Rights predictor to 75 years for Canada anonymous works #136

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

moseshll
Copy link
Collaborator

@moseshll moseshll commented Mar 6, 2024

  • Rights predictor for Canada is now sensitive to the is_pub/anonymous/corporate status of a work
    • Use a new constant CANADA_CORPORATE_TERM set to 75 years
    • Pass is_pub flag to last_source_copyright method
    • Pass along the is_pub flag to all per-country rights predictors
    • Update tests with a separate author death date vs anonymous/pub date example for Canada
      • Add a couple tests for other countries to make sure the change only applies to Canada
  • The overall complexity of RightsPredictor will be addressed in DEV-1057 with a bit of a refactor.

moseshll added 3 commits March 6, 2024 17:20
- Rights predictor for Canada is now sensitive to the is_pub/anonymous/corporate status of a work
  - Use a new constant CANADA_CORPORATE_TERM set to 75 years
  - Pass the is_pub flag to all per-country rights predictors
  - Update tests with a separate author death date vs anonymous/pub date example for Canada
@moseshll moseshll requested a review from mwarin March 7, 2024 19:43
@moseshll moseshll changed the title TTO-184 Rights predictor to 75 for Canada anonymous works TTO-184 Rights predictor to 75 years for Canada anonymous works Mar 7, 2024
Copy link

@mwarin mwarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've asked for a few readability changes, but I see no reason to hold this back.

APPROVE.

lib/CRMS/RightsPredictor.pm Outdated Show resolved Hide resolved
lib/CRMS/RightsPredictor.pm Outdated Show resolved Hide resolved
lib/CRMS/RightsPredictor.pm Show resolved Hide resolved
t/lib/CRMS/RightsPredictor.t Outdated Show resolved Hide resolved
@moseshll moseshll merged commit fc68ca3 into main Mar 11, 2024
1 check passed
@moseshll moseshll deleted the TTO-184_Canada_75 branch March 11, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants