TTO-231 multivalue env email

[moseshll]

This is in response to an unusual behavior noted with University of Kentucky's use of Shib when their users are authenticated for CRMS access. CRMS determines who is who (matching its users against both the crms.users table as well as ht.ht_users) by consulting $ENV{REMOTE_USER} and falling back to $ENV{email}. uky.edu was providing email values like [email protected];[email protected] possibly due to some misconfiguration. I agreed with A&E (after a long slack thread referenced in the ticket) that we should just try to accommodate multiple values as we would fields like eppn. This we have an additional loop over possible multiple values of email where previously we have been assuming it held a single value.

The commits:

• A testable utility routine that parses the ENV{email} value and applies needed transformations.
• Modify the caller subroutine SetupUser to use the new utility. The is the meat of the branch.
• Tidy SetupUser.
• Fix deferencing bug not detected prior to integration test under dev-2

Reviewer:

• Would like a scan of the modified SetupUser in the area of the ENV{email} check -- there is some cleanup work to be done where the code unnecessarily refers to ht_repository and that is the subject of a lower-priority GitHub issue to be addressed later.
• Would like to have a quick review of the added tests. Should extract_env_email take an optional string parameter defaulting to ENV{email} so we don't have to set and restore ENV in the tests?

[mwarin]

scan of the modified SetupUser

Looks good to me. I mean, yes to the cleanup, but I see nothing worth mentioning.

quick review of the added tests

I think I addressed that in my comments.

APPROVE.