Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting feed repo working, shameless green, for mwarin #110

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

mwarin
Copy link
Contributor

@mwarin mwarin commented Jan 18, 2024

Mission: to get the feed repo to a clean state where @mwarin can start working with it.

Turns out we didn't need to do a lot more to get it working, it was mostly a case of a really old docker installation locally. Tests are coming up green both locally and under github actions. Some things (issues with xerces & gnupg) were fixed by @aelkiss in 8b4115d.

Also had to mess around with my ssh keys so I could start using the ssh protocol, because you are no longer allowed to push to workflows with https for some (security?) reason. That's not in the PR either.

Actual changes

Changing docker-compose to hyphenless docker compose and removing a few warnings from the tests.

To review

(You may have to stop or prune existing services.)

cd /tmp
git clone -b validate-cache-usr-local [email protected]:hathitrust/feed ./feed_clean
cd /tmp/feed_clean
docker build
docker compose run test

Expected results:

It'll take several minutes to build and test.

Expect to see some warnings, but ultimately a message that tests passed:
Result: PASS

@mwarin mwarin changed the title Getting feed repo to shameless green for mwarin Getting feed repo working, shameless green, for mwarin Jan 18, 2024
@mwarin mwarin force-pushed the validate-cache-usr-local branch from daebe21 to 99ba69d Compare January 18, 2024 17:12
@mwarin mwarin marked this pull request as ready for review January 18, 2024 17:47
@mwarin mwarin requested review from moseshll and aelkiss January 18, 2024 17:48
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like the no warnings 'redefine' especially - that's always an annoying thing to see, but not one I've (obviously) ever bothered to take care of

@mwarin mwarin merged commit 5e72737 into main Jan 19, 2024
1 check passed
@mwarin
Copy link
Contributor Author

mwarin commented Jun 3, 2024

deleting an old merged branch

@mwarin mwarin deleted the validate-cache-usr-local branch June 3, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants