Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐇: Improve bunnies test suite #139

Merged
merged 3 commits into from
Jul 23, 2024
Merged

🐇: Improve bunnies test suite #139

merged 3 commits into from
Jul 23, 2024

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Jul 23, 2024

Fixes #133

  • Add helper functions to clarify purposes of tests
  • Fixes semantics of one currently-brittle test to ensure that we wait for a message when we expect there to be one
  • Test what we say we're testing when expecting to get a particular job
  • Makes NO_WAIT and RECV_WAIT constants

Fixes #133

* Add helper functions to clarify purposes of tests
* Fixes semantics of one currently-brittle test to ensure that we wait
  for a message when we expect there to be one
* Test what we say we're testing when expecting to get a particular job
* Makes NO_WAIT and RECV_WAIT constants
@aelkiss aelkiss requested review from mwarin and liseli July 23, 2024 18:52
@mwarin mwarin merged commit 5092d14 into main Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address brittle Bunnies test
3 participants