Removing (as of late) unused PackageTypes from feed #141
+7
−4,411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also recommend removing:
The MDLContone stuff was an old pilot; there are things in the repository but I don't think we need support for ingesting them. The Kirtas and Yale material was old one-offs and if we did something like that in the future we would likely first want to transform it to the 'simple' package type. We also don't currently have any epub packages in the repository or any plans to ingest them, but that code is at least tested. I waffle about removing it. I suppose if/when we did epub we could bring it back. I'm just not sure. What do you think? I think we could also remove |
mwarin
force-pushed
the
DEV-1190-feed-remove-packagetypes
branch
from
e35b98f to
fd5f9a8
Compare
mwarin
force-pushed
the
DEV-1190-feed-remove-packagetypes
branch
from
746948e to
6134215
Compare
aelkiss
approved these changes
Jul 26, 2024
mwarin
force-pushed
the
DEV-1190-feed-remove-packagetypes
branch
from
6134215 to
a4b186a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of DEV-1190
Bunch of deleted files, guided by which packagetypes have been used in the last years & input from Aaron.
In addition, a few changes to the TEST namespace (to stop using removed packagetypes) and removing the dependency to the unused
Net::Prometheus(#135).