DEV-1313 (Local ingest doesn't look for material in "failure" directory) #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moseshll
reviewed
Sep 6, 2024
moseshll
reviewed
Sep 6, 2024
moseshll
reviewed
Sep 6, 2024
moseshll
reviewed
Sep 6, 2024
moseshll
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Just fiddly comments and musings. Except for tab thing which as expected I am again being pedantic about. APPROVE in anticipation of a grand tab-squishing party.
EDIT: I forgot to mention that I haven't been able to reliably run the feed test suite over the past years, because I get many failures along the lines of...
# Failed test 'bin/enqueue.pl can queue if there is bib data' by dying:
# Can't locate object method "get" via package "HTFeed::Namespace::TEST"
# at /usr/local/feed/lib/HTFeed/Namespace.pm line 33.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/enqueue.plis an important script for doing operational ingest work, but has not had any tests and is (according to the originating ticket) sometimes behaving oddly. I have been unable to replicate the error condition as described in the originating ticket, but:t/queue.tt/enqueue.t(for testingbin/enqueue.pl)Having
t/enqueue.twill make it easier to test the error condition if/when I ever get closer to it.