Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-1087 Argo Workflows monthly and daily #41

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

moseshll
Copy link
Contributor

@moseshll moseshll commented Apr 18, 2024

  • Use environment variables and settings for history/redirects destination directories.
  • Miscellaneous ease of use changes for the hathifiles generation script.

@moseshll moseshll marked this pull request as draft April 18, 2024 03:07
@coveralls
Copy link

coveralls commented Apr 18, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 484ecd1 on DEV-1087_hathifiles_database_monthly
into c221626 on main.

@moseshll
Copy link
Contributor Author

moseshll commented Jun 5, 2024

This branch is probably not needed. Keeping it around for reference for next steps in Argo metadata workflow.

moseshll added 5 commits June 10, 2024 15:50
- Miscellaneous ease of use changes for the hathifiles generation script.

Use Settings.hathifiles_dir instead of hardcoded path

Add environment variables for history and redirect directories
@moseshll moseshll force-pushed the DEV-1087_hathifiles_database_monthly branch from 0ee7b8d to 484ecd1 Compare June 10, 2024 19:59
@moseshll moseshll changed the title DEV-1087 Argo Workflows DEV-1087 Argo Workflows monthly and daily Jun 10, 2024
@moseshll moseshll marked this pull request as ready for review June 10, 2024 20:03
@moseshll moseshll requested a review from aelkiss June 10, 2024 20:04
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense to me!

@moseshll moseshll merged commit f398155 into main Jun 10, 2024
2 checks passed
@moseshll moseshll deleted the DEV-1087_hathifiles_database_monthly branch June 10, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants