DEV-838: Full MARC record output #28
Conversation
aelkiss
force-pushed
the
DEV-838-full-marc
branch
from
41b0b5a to
70c6e22
Compare
- marc21_full metadata format with full records (save the special Zephir-specific fields) - additional description element for Identify with reference to metadata sharing policy, access & use policy
aelkiss
force-pushed
the
DEV-838-full-marc
branch
from
70c6e22 to
188d20a
Compare
|
Can't merge this at the current time due to policy issues, but feel free to review & then we should close without merging. |
|
@moseshll Since we can't use this as-is, any thoughts on whether we might want to put a feature gate in place so it isn't active and then review/merge this, or just close this PR with no action? I have no idea of the likelihood of ever being able to enable this. The risk if we close this (but leave the branch open) is future merge conflicts/difficulty integrating if we do end up being able to do it. |
|
My opinion: add a gate and merge. I dare to suspect that controlling the feature with an ENV variable (no var set meaning "feature off") will suffice and keep the specs/coverage sparkly. As opposed to scattering |
|
@moseshll See what you think. I hesitate to make this more dynamic (e.g. just based on a setting at startup) in part because it's difficult to test, and we don't have a near-term ability to release this functionality. |
* Leaves unit tests for MARC21 full output enabled * Removes it from provider configuration * Integration tests check that MARC21 full output is not enabled
aelkiss
force-pushed
the
DEV-838-full-marc
branch
from
c3c0855 to
e6b3651
Compare
marc21_full metadata format with full records (save the special Zephir-specific fields)
additional description element for Identify with reference to metadata sharing policy, access & use policy