Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for dev containers #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support for dev containers #31

wants to merge 1 commit into from

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Oct 15, 2024

  • add ruby-lsp and debug gems (ruby-lsp may also need to be installed outside the bundle)
  • add devcontainer.json with extension info

@aelkiss
Support for dev containers
877472e 
* add ruby-lsp and debug gems (ruby-lsp may also need to be installed
  outside the bundle)
* add devcontainer.json with extension info
@aelkiss aelkiss requested a review from moseshll October 15, 2024 20:35
@aelkiss
Copy link
Member Author

aelkiss commented Oct 15, 2024

This works for me with language server & debugging support. I'll try it from a fresh checkout as well.

@coveralls
Copy link

Coverage Status

coverage: 99.038%. remained the same
when pulling 877472e on dev-container
into f51305e on main.

@moseshll
Copy link
Contributor

Note I had to change .devcontainer/devcontainer.json to uncomment and change "runServices": ["web"], in order to get the debugger to do anything but emit errors. Not sure that is something we want in the config or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moseshll moseshll Awaiting requested review from moseshll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelkiss @coveralls @moseshll