Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the unstable package #32

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Stop using the unstable package #32

merged 1 commit into from
Oct 30, 2024

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Oct 21, 2024

  • when we automatically build main, it pushes a tag with the github commit SHA but does not update the 'latest' tag

  • tag-release tags that commit into a 'production' image (and updates latest)

* when we automatically build main, it pushes a tag with the github
  commit SHA but does not update the 'latest' tag

* tag-release tags that commit into a 'production' image and updates
  latest
@aelkiss aelkiss requested a review from Ronster2018 October 21, 2024 14:54
@aelkiss
Copy link
Member Author

aelkiss commented Oct 21, 2024

After this is merged and we update our staging & testing environments not to use the 'unstable' image (which we can test using the deployment action to do so) we can delete the '-unstable' repository

@coveralls
Copy link

Coverage Status

coverage: 99.038%. remained the same
when pulling fe09b88 on remove-unstable-stuff
into 09b0aec on main.

@aelkiss
Copy link
Member Author

aelkiss commented Oct 21, 2024

We should take the cleanup here in the deploy action and make sure we have a template for just the deploy action.

@aelkiss
Copy link
Member Author

aelkiss commented Oct 30, 2024

Reviewed with @Ronster2018 on a call.

@aelkiss aelkiss merged commit 3091013 into main Oct 30, 2024
1 check passed
@aelkiss aelkiss deleted the remove-unstable-stuff branch October 30, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants