fix(graphql): put graphql-yoga back into prod deps to reexport its ty…

…pes (#109)
hattipjs · Dec 30, 2023 · 4987be3 · 4987be3
1 parent 7584a22
commit 4987be3
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 16 deletions.
diff --git a/packages/middleware/graphql/package.json b/packages/middleware/graphql/package.json
@@ -41,12 +41,12 @@
     "@hattip/compose": "workspace:*",
     "@hattip/core": "workspace:*",
     "dset": "^3.1.2",
+    "graphql-yoga": "^4.0.4",
     "tslib": "^2.6.2",
     "urlpattern-polyfill": "^9.0.0"
   },
   "devDependencies": {
     "@graphql-yoga/subscription": "^4.0.0",
-    "graphql-yoga": "^4.0.4",
     "@cyco130/eslint-config": "^3.3.2",
     "@hattip/polyfills": "workspace:*",
     "@types/node": "^20.5.7",

diff --git a/packages/middleware/graphql/tsup.config.ts b/packages/middleware/graphql/tsup.config.ts
@@ -12,6 +12,10 @@ export default defineConfig([
 		target: "node14",
 		shims: false,
 		dts: true,
+		// We wan't to bundle graphql-yoga so that we can use the
+		// global fetch instead of @whatwg-node/fetch. But we still
+		// want graphql-yoga in the dependencies to be able to resolve
+		// the types.
 		noExternal: ["graphql-yoga"],
 		esbuildPlugins: [
 			{

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml