Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip node-fetch and @whatwg-node/fetch tests on Node 21+ #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aleclarson
Copy link
Contributor

@aleclarson aleclarson commented Nov 22, 2024

The --no-experimental-fetch flag was removed in Node 21:
nodejs/node#52611

When native fetch exists, node-fetch and @whatwg-node/fetch polyfills are not used. So in Node 21+, the integration tests for those polyfills are simply testing native fetch.

Therefore, we can skip the integration tests for the node-fetch and @whatwg-node/fetch polyfills when the Node major version is 21 or higher.

@aleclarson
Copy link
Contributor Author

CI failure appears to be unrelated to this PR

@aleclarson aleclarson requested a review from cyco130 November 22, 2024 17:28
@cyco130
Copy link
Member

cyco130 commented Nov 26, 2024

I want to remove those entry points anyway. It shouldn't be Hattip's responsibility to polyfill fetch anymore (it made sense back in Node 14/16 days).

@cyco130
Copy link
Member

cyco130 commented Nov 30, 2024

Hmm, now I'm confused. My node v21.7.3. and v22.11.0 still accept --no-experimental-fetch. Maybe no need to rush it yet?

@aleclarson
Copy link
Contributor Author

Ah, looks like they removed it in v23

@cyco130
Copy link
Member

cyco130 commented Nov 30, 2024

Well, otherwise CI would have started failing much earlier :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants