Updated make links #2575
Updated make links #2575
Conversation
There was a problem hiding this comment.
Hi, thank you for contributing!
Makefile lgtm, can't test the .ps1, tho...
Also, if you want, you might consider adding your name to the contributors file.
| $(wget) https://github.com/hawkthorne/tmx2lua/archive/master.zip | ||
| unzip master.zip | ||
| rm -rf master.zip | ||
| make -C tmx2lua-master |
There was a problem hiding this comment.
| make -C tmx2lua-master | |
| make -C tmx2lua-master install | |
| make -C tmx2lua-master |
When remaking the file, make sure that go-tmx/tmx is installed.
|
This is really great. I just have a couple notes and then I think we can merge this... I would prefer if we use the GitHub releases links for LÖVE instead of using archive.org Additionally, we should change the Lastly, please see #2555 for how to update the conf file that states which version of LÖVE the game was built for and make that also match 0.10.2 |
|
I think that should take care of it! If there's anything else just lmk |
|
One last thing I just realized is the need to update line 57 of the Makefile as well to match the version pinning we did in |
|
My fault for not checking this before I suggested this, but it looks like the PPA doesn't support that older version of LÖVE anymore. Instead we'll need to download and install these packages for Linux builds: |
The link to love-0.10.1 was dead so I updated it to a 0.10.2 link that works. The tmx2lua OSX and Linux code wasn't working in .tar format so I changed it to downloading the .zip and opening from there. It runs perfectly when I run it on my mac or through my emulator, but if there's any issue let me know and I'll work it out.