Fix issues in Assert.exception().
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the IDE to notice it, without being as disruptive as the `@:deprecated` metadata.
This fixes a null pointer error in the tests, moves the `try catch` block to the top of the function for easier readability, reduces the total amount of code, and standardizes the failure messages. (Among other things, it used to print a double space if `type` was null.)
On that target, `Std.isOfType()` will return true as long as `e` is any enum value, making it useless for the intended test.
|
Thanks! What's the issue with C++? |
|
It seems to implement enums slightly differently, making it unable to tell one enum type from another.
So basically, the test can't be performed in C++. |
|
It's an issue of the Haxe itself: HaxeFoundation/haxe#11442 |
|
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I already figured out the issues causing CI to fail, I figured I could apply the same solution to the new function. Plus I fixed the documentation, re-organized the code for clarity, and made the failure messages look better.
Edit: but apparently something else changed. I'm working on it.Edit 2: it was target-specific weirdness.Supersedes #127 and #128.