[CN-1274] Update client configs to use public IP addresses (#18)

* update java and nodejs client examples for smart client * update python unisocket example * revert IP address in nodejs example * update dotnet examples * update java and dotnet example * sync python example
hazelcast-guides · May 10, 2024 · 02f8deb · 02f8deb
1 parent aa24573
commit 02f8deb
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 9 deletions.
diff --git a/docs/modules/ROOT/pages/hazelcast-platform-operator-expose-externally.adoc b/docs/modules/ROOT/pages/hazelcast-platform-operator-expose-externally.adoc
@@ -176,7 +176,6 @@ logging.basicConfig(level=logging.INFO)
 
 client = hazelcast.HazelcastClient(
     cluster_members=["<EXTERNAL-IP>"],
-    use_public_ip=True,
     smart_routing=False,
 )
 ----
@@ -191,7 +190,7 @@ var options = new HazelcastOptionsBuilder()
     .With((configuration, options) =>
     {
         options.LoggerFactory.Creator = () => LoggerFactory.Create(loggingBuilder => loggingBuilder.AddConfiguration(configuration.GetSection("logging")).AddConsole());
-        options.Networking.Addresses.Add("<EXTERNAL IP>");
+        options.Networking.Addresses.Add("<EXTERNAL-IP>");
         options.Networking.SmartRouting = false;
     })
     .Build();
@@ -355,9 +354,6 @@ image::smart.jpg[Hazelcast Smart Client]
 
 === Start the Hazelcast Cluster
 
-
-
-
 Run the following command to create the Hazelcast cluster with Expose Externally feature enabled using Smart type.
 
 [source, shell]
@@ -441,6 +437,7 @@ Java::
 ----
 ClientConfig config = new ClientConfig();
 config.getNetworkConfig().addAddress("<EXTERNAL-IP>");
+config.getProperties().setProperty(ClientProperty.DISCOVERY_SPI_PUBLIC_IP_ENABLED.toString(), "true");
 ----
 --
 
@@ -456,6 +453,9 @@ const clientConfig = {
         clusterMembers: [
             '<EXTERNAL-IP>'
         ]
+    },
+    properties: {
+        ['hazelcast.discovery.public.ip.enabled']: true
     }
 };
 const client = await Client.newHazelcastClient(clientConfig);
@@ -513,8 +513,9 @@ var options = new HazelcastOptionsBuilder()
     .With((configuration, options) =>
     {
         options.LoggerFactory.Creator = () => LoggerFactory.Create(loggingBuilder => loggingBuilder.AddConfiguration(configuration.GetSection("logging")).AddConsole());
-        options.Networking.Addresses.Add("<EXTERNAL IP>");
+        options.Networking.Addresses.Add("<EXTERNAL-IP>");
         options.Networking.UsePublicAddresses = true;
+
     })
     .Build();
 var client = await HazelcastClientFactory.StartNewClientAsync(options);

diff --git a/dotnet-unisocket/csharp_example.cs b/dotnet-unisocket/csharp_example.cs
@@ -12,7 +12,7 @@ static async Task Main(string[] args)
             .With((configuration, options) =>
             {
                 options.LoggerFactory.Creator = () => LoggerFactory.Create(loggingBuilder => loggingBuilder.AddConfiguration(configuration.GetSection("logging")).AddConsole());
-                options.Networking.Addresses.Add("<EXTERNAL IP>");
+                options.Networking.Addresses.Add("<EXTERNAL-IP>");
                 options.Networking.SmartRouting = false;
             })
             .Build();

diff --git a/dotnet/Program.cs b/dotnet/Program.cs
@@ -10,7 +10,7 @@ static async Task Main(string[] args)
             .With((configuration, options) =>
             {
                 options.LoggerFactory.Creator = () => LoggerFactory.Create(loggingBuilder => loggingBuilder.AddConfiguration(configuration.GetSection("logging")).AddConsole());
-                options.Networking.Addresses.Add("<EXTERNAL IP>");
+                options.Networking.Addresses.Add("<EXTERNAL-IP>");
                 options.Networking.UsePublicAddresses = true;
             })
             .Build();

diff --git a/java/src/main/java/com/hazelcast/Main.java b/java/src/main/java/com/hazelcast/Main.java
@@ -2,6 +2,7 @@
 
 import com.hazelcast.client.HazelcastClient;
 import com.hazelcast.client.config.ClientConfig;
+import com.hazelcast.client.properties.ClientProperty;
 import com.hazelcast.core.HazelcastInstance;
 import com.hazelcast.map.IMap;
 
@@ -11,6 +12,7 @@ public class Main {
     public static void main(String[] args) throws Exception {
         ClientConfig config = new ClientConfig();
         config.getNetworkConfig().addAddress("<EXTERNAL-IP>");
+        config.getProperties().setProperty(ClientProperty.DISCOVERY_SPI_PUBLIC_IP_ENABLED.toString(), "true");
         HazelcastInstance client = HazelcastClient.newHazelcastClient(config);
 
         System.out.println("Successful connection!");

diff --git a/nodejs/client.js b/nodejs/client.js
@@ -7,6 +7,9 @@ const clientConfig = {
         clusterMembers: [
             '<EXTERNAL-IP>'
         ]
+    },
+    properties: {
+        ['hazelcast.discovery.public.ip.enabled']: true
     }
 };
 

diff --git a/python-unisocket/main.py b/python-unisocket/main.py
@@ -7,7 +7,6 @@
 
 client = hazelcast.HazelcastClient(
     cluster_members=["<EXTERNAL-IP>"],
-    use_public_ip=True,
     smart_routing=False,
 )