[CLC-311, CLC-314, CLC-326] DMT Updates #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* transition to event driven arch with ITopic
# Conflicts: # base/commands/migration/const.go # base/commands/migration/migration_start.go # base/commands/migration/stages.go
✅ Deploy Preview for eclectic-sawine-19fcf1 canceled.
|
yuce
approved these changes
Sep 28, 2023
srknzl
reviewed
Oct 12, 2023
yuce
requested changes
Oct 19, 2023
| Must(tcx.CLC().Execute(ctx, "status")) | ||
| }) | ||
| // statusRunner removes __datamigrations_in_progress list, so we should give some time to command to read it first | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
Sleeps may cause flaky tests.
Let's use it.Eventually instead to wait for the condition necessary to proceed.
There was a problem hiding this comment.
There is no condition to wait in here, so I cannot use Eventually.
srknzl
approved these changes
Oct 20, 2023
kutluhanmetin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.