[CLC-425]: Print Warnings Before Exit #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srknzl
reviewed
Oct 31, 2023
| ec.Logger().Error(err) | ||
| return | ||
| } | ||
| ec.PrintlnUnnecessary("* " + strings.Join(warnings, "\n* ")) |
There was a problem hiding this comment.
If there're lots of them, it can be more reasonable to point to the migration report instead. The warnings will be in the report as well. If there're less than 5 we can directly print them
There was a problem hiding this comment.
I think there won't be too many warning that makes it hard to display in the terminal.
There was a problem hiding this comment.
There can be in the future. We'll keep adding things to warnings field.
There was a problem hiding this comment.
Note that, it's not just for future. 1000 ds skips can even happen now.
srknzl
reviewed
Nov 3, 2023
Comment on lines
285
to
287
| if len(warnings) <= 5 { | ||
| ec.PrintlnUnnecessary("* " + strings.Join(warnings, "\n* ")) | ||
| } |
There was a problem hiding this comment.
Can we add a else block that says "you have x warnings that you can find in your migration report" ?
yuce
approved these changes
Nov 3, 2023
srknzl
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.