Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLC-313]: Add Estimate Command to DMT #422

Merged
merged 7 commits into from
Nov 7, 2023
Merged

[CLC-313]: Add Estimate Command to DMT #422

merged 7 commits into from
Nov 7, 2023

Conversation

kutluhanmetin
Copy link
Contributor

No description provided.

@kutluhanmetin kutluhanmetin requested review from yuce and srknzl November 1, 2023 08:02
srknzl
srknzl reviewed Nov 2, 2023
View reviewed changes
base/commands/migration/estimate_stages.go Show resolved Hide resolved
base/commands/migration/estimate_stages.go Outdated Show resolved Hide resolved
base/commands/migration/estimate_stages.go Show resolved Hide resolved
base/commands/migration/const.go Show resolved Hide resolved
@kutluhanmetin kutluhanmetin requested a review from srknzl November 2, 2023 11:15
yuce
yuce requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@yuce yuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas, will continue to review...

base/commands/migration/estimate.go Outdated Show resolved Hide resolved
base/commands/migration/estimate.go Outdated Show resolved Hide resolved
base/commands/migration/estimate_it_test.go Outdated Show resolved Hide resolved
base/commands/migration/estimate_it_test.go Outdated Show resolved Hide resolved
base/commands/migration/estimate_it_test.go Outdated Show resolved Hide resolved
@kutluhanmetin kutluhanmetin requested a review from yuce November 3, 2023 08:20
yuce
yuce requested changes Nov 3, 2023
View reviewed changes
base/commands/migration/estimate.go Outdated Show resolved Hide resolved
internal/str/str.go Outdated Show resolved Hide resolved
@kutluhanmetin kutluhanmetin requested a review from yuce November 4, 2023 17:31
@kutluhanmetin kutluhanmetin merged commit 0fd24c6 into hazelcast:dmt Nov 7, 2023
5 checks passed
@degerhz degerhz added this to the Data Migration Tool [Phase 1] milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srknzl srknzl srknzl approved these changes

@yuce yuce yuce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Data Migration Tool [Phase 1]
Development

Successfully merging this pull request may close these issues.
4 participants
@kutluhanmetin @yuce @srknzl @degerhz